Hi,
On Thu, Apr 24, 2025 at 09:14:46PM -0400, Sasha Levin wrote:
[ Sasha's backport helper bot ]
Hopefully this reply can reach also non-bots...
Hi,
Summary of potential issues: ❌ Build failures detected ⚠️ Found matching upstream commit but patch is missing proper reference to it
Patch was intended for 6.1. branch only and this intention is expressed in the Cc: tags where also additional patch prerequisite was specified, but obviously not picked up.
Found matching upstream commit: 3e5e4a801aaf4283390cc34959c6c48f910ca5ea
WARNING: Author mismatch between patch and found commit: Backport author: Ladislav Michloss-lists@triops.cz Commit author: Ping-Ke Shihpkshih@realtek.com
Also noted in the patch description. Driver undergone significant rewrite after 6.1 so change needed to be done different way. Backtrace also mine from 6.1 kernel.
Note: The patch differs from the upstream commit:
1: 3e5e4a801aaf4 < -: ------------- wifi: rtw88: use ieee80211_purge_tx_queue() to purge TX skb
-: ------------- > 1: d12acd7bc3d4c Linux 6.14.3
Results of testing on various branches:
| Branch | Patch Apply | Build Test | |---------------------------|-------------|------------| | stable/linux-6.14.y | Success | Success | | stable/linux-6.12.y | Success | Success | | stable/linux-6.6.y | Success | Success | | stable/linux-6.1.y | Success | Failed | | stable/linux-5.15.y | Success | Failed | | stable/linux-5.10.y | Success | Success | | stable/linux-5.4.y | Success | Success |
Build Errors: Build error for stable/linux-6.1.y: drivers/net/wireless/realtek/rtw88/main.c: In function 'rtw_core_deinit': drivers/net/wireless/realtek/rtw88/main.c:2149:9: error: implicit declaration of function 'ieee80211_purge_tx_queue'; did you mean 'ieee80211_wake_queue'? [-Wimplicit-function-declaration] 2149 | ieee80211_purge_tx_queue(rtwdev->hw, &rtwdev->tx_report.queue); | ^~~~~~~~~~~~~~~~~~~~~~~~ | ieee80211_wake_queue make[6]: *** [scripts/Makefile.build:250: drivers/net/wireless/realtek/rtw88/main.o] Error 1 drivers/net/wireless/realtek/rtw88/tx.c: In function 'rtw_tx_report_purge_timer': drivers/net/wireless/realtek/rtw88/tx.c:172:9: error: implicit declaration of function 'ieee80211_purge_tx_queue'; did you mean 'ieee80211_wake_queue'? [-Wimplicit-function-declaration] 172 | ieee80211_purge_tx_queue(rtwdev->hw, &tx_report->queue); | ^~~~~~~~~~~~~~~~~~~~~~~~ | ieee80211_wake_queue make[6]: *** [scripts/Makefile.build:250: drivers/net/wireless/realtek/rtw88/tx.o] Error 1 make[6]: Target 'drivers/net/wireless/realtek/rtw88/' not remade because of errors. make[5]: *** [scripts/Makefile.build:503: drivers/net/wireless/realtek/rtw88] Error 2 make[5]: Target 'drivers/net/wireless/realtek/' not remade because of errors. make[4]: *** [scripts/Makefile.build:503: drivers/net/wireless/realtek] Error 2 make[4]: Target 'drivers/net/wireless/' not remade because of errors. make[3]: *** [scripts/Makefile.build:503: drivers/net/wireless] Error 2 make[3]: Target 'drivers/net/' not remade because of errors. make[2]: *** [scripts/Makefile.build:503: drivers/net] Error 2 make[2]: Target 'drivers/' not remade because of errors. make[1]: *** [scripts/Makefile.build:503: drivers] Error 2 make[1]: Target './' not remade because of errors. make: *** [Makefile:2010: .] Error 2 make: Target '__all' not remade because of errors.
Build error for stable/linux-5.15.y: drivers/net/wireless/realtek/rtw88/main.c: In function 'rtw_core_deinit': drivers/net/wireless/realtek/rtw88/main.c:1912:9: error: implicit declaration of function 'ieee80211_purge_tx_queue'; did you mean 'ieee80211_wake_queue'? [-Werror=implicit-function-declaration] 1912 | ieee80211_purge_tx_queue(rtwdev->hw, &rtwdev->tx_report.queue); | ^~~~~~~~~~~~~~~~~~~~~~~~ | ieee80211_wake_queue cc1: some warnings being treated as errors make[5]: *** [scripts/Makefile.build:289: drivers/net/wireless/realtek/rtw88/main.o] Error 1 drivers/net/wireless/realtek/rtw88/tx.c: In function 'rtw_tx_report_purge_timer': drivers/net/wireless/realtek/rtw88/tx.c:168:9: error: implicit declaration of function 'ieee80211_purge_tx_queue'; did you mean 'ieee80211_wake_queue'? [-Werror=implicit-function-declaration] 168 | ieee80211_purge_tx_queue(rtwdev->hw, &tx_report->queue); | ^~~~~~~~~~~~~~~~~~~~~~~~ | ieee80211_wake_queue cc1: some warnings being treated as errors make[5]: *** [scripts/Makefile.build:289: drivers/net/wireless/realtek/rtw88/tx.o] Error 1 make[5]: Target '__build' not remade because of errors. make[4]: *** [scripts/Makefile.build:552: drivers/net/wireless/realtek/rtw88] Error 2 make[4]: Target '__build' not remade because of errors. make[3]: *** [scripts/Makefile.build:552: drivers/net/wireless/realtek] Error 2 make[3]: Target '__build' not remade because of errors. make[2]: *** [scripts/Makefile.build:552: drivers/net/wireless] Error 2 make[2]: Target '__build' not remade because of errors. make[1]: *** [scripts/Makefile.build:552: drivers/net] Error 2 make[1]: Target '__build' not remade because of errors. make: *** [Makefile:1911: drivers] Error 2 make: Target '__all' not remade because of errors.