Re: [patch 09/14] tmpfs: disallow CONFIG_TMPFS_INODE64 on alpha

On Wed, Feb 10, 2021 at 02:34:08PM +0100, Heiko Carstens wrote:

diff --git a/include/linux/types.h b/include/linux/types.h index a147977602b5..1e9d0a2c1dba 100644 --- a/include/linux/types.h +++ b/include/linux/types.h @@ -14,7 +14,7 @@ typedef u32 __kernel_dev_t; typedef __kernel_fd_set fd_set; typedef __kernel_dev_t dev_t; -typedef __kernel_ino_t ino_t; +typedef __kernel_ulong_t ino_t; typedef __kernel_mode_t mode_t; typedef unsigned short umode_t; typedef u32 nlink_t; @@ -189,7 +189,11 @@ struct hlist_node { struct ustat { __kernel_daddr_t f_tfree;

• __kernel_ino_t f_tinode;

+#ifdef ARCH_HAS_32BIT_F_TINODE

• unsigned int f_tinode;

+#else

• unsigned long f_tinode;

+#endif

Of course that should have been CONFIG_ARCH_32BIT_USTAT_F_TINODE in order to not break the existing ABI for alpha and s390.