On Mon, Jun 09, 2025 at 11:39:35AM +0200, Thomas Weißschuh wrote:
The charge-control subsystem in the ChromeOS EC is not strictly tied to its USB-PD subsystem. Since commit 7613bc0d116a ("mfd: cros_ec: Don't load charger with UCSI") the presence of EC_FEATURE_UCSI_PPM would inhibit the probing of the charge-control driver. Furthermore recent versions of the EC firmware in Framework laptops hard-disable EC_FEATURE_USB_PD to avoid probing cros-usbpd-charger, which then also breaks cros-charge-control.
Instead use the dedicated EC_FEATURE_CHARGER.
Link: https://github.com/FrameworkComputer/EmbeddedController/commit/1d7bcf1d50137... Fixes: 555b5fcdb844 ("mfd: cros_ec: Register charge control subdevice") Cc: stable@vger.kernel.org Tested-by: Tom Vincent linux@tlvince.com Signed-off-by: Thomas Weißschuh linux@weissschuh.net
Reviewed-by: Tzung-Bi Shih tzungbi@kernel.org