Re: [PATCH 1/2] mfd: vexpress-sysreg: check the return value of devm_gpiochip_add_data()

On Mon, Aug 11, 2025 at 3:36 PM Bartosz Golaszewski brgl@bgdev.pl wrote:

From: Bartosz Golaszewski bartosz.golaszewski@linaro.org

Commit 974cc7b93441 ("mfd: vexpress: Define the device as MFD cells") removed the return value check from the call to gpiochip_add_data() (or rather gpiochip_add() back then and later converted to devres) with no explanation. This function however can still fail, so check the return value and bail-out if it does.

Cc: stable@vger.kernel.org Fixes: 974cc7b93441 ("mfd: vexpress: Define the device as MFD cells") Signed-off-by: Bartosz Golaszewski bartosz.golaszewski@linaro.org

Reviewed-by: Linus Walleij linus.walleij@linaro.org

Yours, Linus Walleij