Re: [PATCH v2 1/2] drm/atomic: Allow vblank-enabled + self-refresh "disable"

On Fri, Jan 06, 2023 at 05:27:33PM -0800, Brian Norris wrote:

On Fri, Jan 6, 2023 at 5:23 PM Brian Norris briannorris@chromium.org wrote:

...

v2:

• add 'ret != 0' warning case for self-refresh
• describe failing test case and relation to drm/rockchip patch better

Ugh, there's always something you remember right after you hit send: I forgot to better summarize some of the other discussion from v1, and alternatives we didn't entertain. I'll write that up now (not sure whether in patch 1 or 2) and plan on sending a v3 for next week, in case there are any other comments I should address at the same time.

For me it needs to be in the helper patch, since anyone not doing rockchip work will otherwise never find it. But you can also duplicate the discussion summary into the 2nd patch, doesn't really hurt. -Daniel