Re: [PATCH] PCI/portdrv: do not disable device on remove()

On 5/22/2018 10:24 PM, Lukas Wunner wrote:

On Tue, May 22, 2018 at 01:58:00PM -0400, Sinan Kaya wrote:

...

--- a/drivers/pci/pcie/portdrv_core.c +++ b/drivers/pci/pcie/portdrv_core.c @@ -409,7 +409,6 @@ void pcie_port_device_remove(struct pci_dev *dev) { device_for_each_child(&dev->dev, NULL, remove_iter); pci_free_irq_vectors(dev);

• pci_disable_device(dev);

}

Shutdown aside, pci_disable_device() is also not called in the ->remove path with this patch, right? Seems wrong. E.g. when unbinding the driver from the root port device, or when unplugging a port (happens all the time with Thunderbolt).

Agreed. I'll spin another version where I skip disable on shutdown path only.

Thanks,

Lukas