Sorry for the incorrect commit message formatting. I'll resolve this in a v3 update.
What prevents this from changing right after checking it?
There is nothing that prevents the connection status from changing just after this is checked, but that is true of most of the values we are using to set power supply properties. If there is a connection change, ucsi_port_psy_changed() will be called from ucsi_handle_connector_change() in ucsi.c. This then calls power_supply_changed() which should signal to userspace or other drivers that this value needs to be reevaluated based on the updated connector status.
-Jameson