Re: [PATCH 5.4] bcache: initialize 'sb_page' in register_bcache()

On Wed, Apr 29, 2020 at 06:38:17PM +0000, Tom Saeger wrote:

commit 393b8509be33 (bcache: rework error unwinding in register_bcache)

introduced compile warning: warning: 'sb_page' may be used uninitialized in this function [-Wmaybe-uninitialized]

Use 'sb_page' initialization prior to 393b8509be33.

Fixes: 393b8509be33 (bcache: rework error unwinding in register_bcache) Cc: stable@vger.kernel.org # 5.4.x Signed-off-by: Tom Saeger tom.saeger@oracle.com

---

This addresses warning only seen in 5.4.22+. Upstream avoids this in a different way.

What is the "different way"?

And why am I not seeing this warning in my builds? What version of gcc are you using?

thanks,

greg k-h