27 Oct
2025
27 Oct
'25
9:24 a.m.
On Sat, Oct 25, 2025, at 17:55, Sasha Levin wrote:
From: Arnd Bergmann arnd@arndb.de
[ Upstream commit d5d299e7e7f6b4ead31383d4abffca34e4296df0 ]
The em28xx driver uses the old-style gpio_request_one() interface to switch the lna on the PCTV 290E card.
This interface is becoming optional and should no longer be called by portable drivers. As I could not figure out an obvious replacement, select the new GPIOLIB_LEGACY symbol as a workaround.
Signed-off-by: Arnd Bergmann arnd@arndb.de Signed-off-by: Hans Verkuil hverkuil+cisco@kernel.org Signed-off-by: Sasha Levin sashal@kernel.org
LLM Generated explanations, may be completely bogus:
YES
- What it fixes: Prevents build breakage when `GPIOLIB=y` but the legacy GPIO consumer API is disabled. `gpio_request_one()` is only declared when `CONFIG_GPIOLIB_LEGACY` is enabled (see `include/linux/gpio.h:88`), so compiling code guarded only by `CONFIG_GPIOLIB` fails if legacy support is off.
It's not needed for stable and has no effect in 6.17. This is only a preparation for a later change.
Arnd