Re: [PATCH] net: usb: pegasus: fix memory leak on usb_submit_urb() failure

On 26-01-02 23:02:53, Andrew Lunn wrote:

...

Sure, will do. However, my v2 patch makes use of __free() cleanup functionality, which in turn only applies back to v6.6 stable kernels.

I would suggest not using the magical __free() cleanup.

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#using-...

Low level cleanup constructs (such as __free()) can be used when
building APIs and helpers, especially scoped iterators. However,
direct use of __free() within networking core and drivers is
discouraged. Similar guidance applies to declaring variables
mid-function.

Heh, __free() is OK for APIs, but not drivers...

Maybe this text is a relic from the times auto cleanup was not fully understood?

Petko