Re: [PATCH 0/2] usb: dwc3: gadget: Check for multiple start/stop

On 21-01-08 02:40:55, Thinh Nguyen wrote:

Hi Peter,

Peter Chen wrote:

...

On 21-01-05 08:56:28, Thinh Nguyen wrote:

...

Add some checks to avoid going through the start/stop sequence if the gadget had already started/stopped. This series base-commit is Greg's usb-linus branch.

Hi Thinh,

What's the sequence your could reproduce it?

Peter

You can test as follow:

# echo connect > /sys/class/udc/<UDC>/soft_connect # echo connect > /sys/class/udc/<UDC>/soft_connect

and

# echo disconnect > /sys/class/udc/<UDC>/soft_connect # echo disconnect > /sys/class/udc/<UDC>/soft_connect

Thinh

Thanks, now I reproduce the issue. Another improvement you might consider adding is checking return value for usb_gadget_udc_start at soft_connect_store.