Re: [PATCH v4.14y - v5.14y] PCI/MSI: Destroy sysfs before freeing entries

On Mon, Nov 15, 2021 at 08:37:43PM +0100, Thomas Gleixner wrote:

Commit 3735459037114d31e5acd9894fad9aed104231a0 uptream

free_msi_irqs() frees the MSI entries before destroying the sysfs entries which are exposing them. Nothing prevents a concurrent free while a sysfs file is read and accesses the possibly freed entry.

Move the sysfs release ahead of freeing the entries.

Fixes: 1c51b50c2995 ("PCI/MSI: Export MSI mode using attributes, not kobjects") Signed-off-by: Thomas Gleixner tglx@linutronix.de Reviewed-by: Greg Kroah-Hartman gregkh@linuxfoundation.org Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/87sfw5305m.ffs@tglx

---

Backport applies to 4.14.y up to 5.14.y series

All now queued up, thanks.

greg k-h