On Tue, Jun 22, 2021 at 06:06:22PM -0300, Guilherme G. Piccoli wrote:
From: Al Viro viro@zeniv.linux.org.uk
commit 7b745a4e4051e1bbce40e0b1c2cf636c70583aa4 upstream.
new_sb is left uninitialized in case of early failures in kernfs_mount_ns(), and while IS_ERR(root) is true in all such cases, using IS_ERR(root) || !new_sb is not a solution - IS_ERR(root) is true in some cases when new_sb is true.
Make sure new_sb is initialized (and matches the reality) in all cases and fix the condition for dropping kobj reference - we want it done precisely in those situations where the reference has not been transferred into a new super_block instance.
Signed-off-by: Al Viro viro@zeniv.linux.org.uk Signed-off-by: Guilherme G. Piccoli gpiccoli@canonical.com
I'd like to protest this patch title heheh But I think it's better to keep consistency with upstream. It's the same case as patch 1 of the series, no clear reason for its absence in stable. Build-tested on x86-64 with defconfig.
Both now queued up, thanks.
greg k-h