From: Filipe Manana fdmanana@suse.com
commit b777d279ff31979add57e8a3f810bceb7ef0cfb7 upstream.
At btrfs_orphan_cleanup(), if we were able to find the inode, we do an iput() on the inode, then if btrfs_drop_verity_items() succeeds and then either btrfs_start_transaction() or btrfs_del_orphan_item() fail, we do another iput() in the respective error paths, resulting in an extra iput() on the inode.
Fix this by setting inode to NULL after the first iput(), as iput() ignores a NULL inode pointer argument.
Fixes: a13bb2c03848 ("btrfs: add missing iputs on orphan cleanup failure") CC: stable@vger.kernel.org # 6.4 Reviewed-by: Boris Burkov boris@bur.io Signed-off-by: Filipe Manana fdmanana@suse.com Signed-off-by: David Sterba dsterba@suse.com Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org --- fs/btrfs/inode.c | 1 + 1 file changed, 1 insertion(+)
--- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -3618,6 +3618,7 @@ int btrfs_orphan_cleanup(struct btrfs_ro if (inode) { ret = btrfs_drop_verity_items(BTRFS_I(inode)); iput(inode); + inode = NULL; if (ret) goto out; }