Hi Frieder,
frieder.schrempf@kontron.de wrote on Wed, 9 Oct 2024 15:33:11 +0200:
On 09.10.24 2:50 PM, Miquel Raynal wrote:
These four chips:
- W25N512GW
- W25N01GW
- W25N01JW
- W25N02JW
all require a single bit of ECC strength and thus feature an on-die Hamming-like ECC engine. There is no point in filling a ->get_status() callback for them because the main ECC status bytes are located in standard places, and retrieving the number of bitflips in case of corrected chunk is both useless and unsupported (if there are bitflips, then there is 1 at most, so no need to query the chip for that).
Without this change, a kernel warning triggers every time a bit flips.
Fixes: 6a804fb72de5 ("mtd: spinand: winbond: add support for serial NAND flash") Cc: stable@vger.kernel.org Signed-off-by: Miquel Raynal miquel.raynal@bootlin.com
I had a quick look at the datasheets and this seems correct to me.
Thanks a lot for the rapid review!
Reviewed-by: Frieder Schrempf frieder.schrempf@kontron.de
Thanks, Miquèl