On Wed, May 30, 2018 at 10:04:51PM +0200, Greg Kroah-Hartman wrote:
On Wed, May 30, 2018 at 09:34:34PM +0200, Arnd Bergmann wrote:
On Wed, May 30, 2018 at 9:24 PM, Greg Kroah-Hartman
Why is that not an option enabled for all arches right now for gcc-8?
I would still want this warning enabled by default in future kernels, just disabled for the system call definitions (until we decide to rework the way they are defined).
What I'd suggest we do is a series of patches:
- disable both -Wno-attribute-alias and -Wstringop-truncation by
default, but leave them enabled in 'make W=1'. Mark this one for stable backports 2. add a macro to let users disable warnings locally within a file, based on _Pragma("GCC diagnostic ...") 3. change the system call macros to disable -Wno-attribute-alias inside of the SYSCALL_DEFINEx() macros 4. turn on -Wno-attribute-alias again by default.
That sounds like a good plan to me.
Agreed.
Guenter