On Tue Jun 24, 2025 at 9:24 AM CEST, Thorsten Leemhuis wrote:
[CCing Miguel (JFYI) as well as Christian, who reported the build error[1] with 6.15.4-rc1 (which I'm seeing as well[2]) caused by the patch this mail is about according to Benno.]
Thanks!
[1] https://lore.kernel.org/all/a0ebb389-f088-417b-9fd4-ac8c100d206f@heusel.eu/
[2] https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/fedora-rc...
On 24.06.25 01:14, Benno Lossin wrote:
On Mon Jun 23, 2025 at 3:07 PM CEST, Greg Kroah-Hartman wrote:
6.15-stable review patch. If anyone has any objections, please let me know.
From: Danilo Krummrich dakr@kernel.org
[ Upstream commit f744201c6159fc7323c40936fd079525f7063598 ]
In Devres::drop() we first remove the devres action and then drop the wrapped device resource.
The design goal is to give the owner of a Devres object control over when the device resource is dropped, but limit the overall scope to the corresponding device being bound to a driver.
[...] This is missing the prerequisite patch #1 from
https://lore.kernel.org/all/20250612121817.1621-1-dakr@kernel.orgYou afaics mean 1b56e765bf8990 ("rust: completion: implement initial abstraction") [v6.16-rc3]
Yes that is the prerequisite.
– which did not cleanly apply to 6.15.4-rc1 in
In which repository is that tag? I didn't find it in the stable tree.
I tried applying it on top of v6.15.3 and that also results in a conflict, but only in `bindgen_helpers.h` and `helpers.c`, so we can simply provide a fixed patch.
@Danilo, I think this should be backported, how do you want to proceed?
--- Cheers, Benno
a quick test; it was also not possible to revert this patch ("rust: devres: fix race in Devres::drop()") cleanly; reverting worked after reverting "rust: devres: do not dereference to the internal Revocable" First, but that lead to another build error: https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/fedora-rc...
Ciao, Thorsten