Hi!
The function mux_get_parent() uses qcom_find_src_index() to find the parent clock index, which is incorrect: qcom_find_src_index() uses src enum for the lookup, while mux_get_parent() should use cfg field (which corresponds to the register value). Add qcom_find_cfg_index() function doing this kind of lookup and use it for mux parent lookup.
This appears to have problems with error handling.
+++ b/drivers/clk/qcom/clk-regmap-mux.c @@ -36,7 +36,7 @@ static u8 mux_get_parent(struct clk_hw * val &= mask; if (mux->parent_map)
return qcom_find_src_index(hw, mux->parent_map, val);
return qcom_find_cfg_index(hw, mux->parent_map, val);return val; }
So this returns u8.
+int qcom_find_cfg_index(struct clk_hw *hw, const struct parent_map *map, u8 cfg) +{
- int i, num_parents = clk_hw_get_num_parents(hw);
- for (i = 0; i < num_parents; i++)
if (cfg == map[i].cfg)return i;- return -ENOENT;
+}
In case of error, -ENOENT will be cast to u8 in caller. I don't believe that is correct.
Best regards, Pavel