1 Jun
2021
1 Jun
'21
6:35 p.m.
On 6/1/21 11:14 AM, Andy Lutomirski wrote:
Nit: Could we move the detailed comments about TIF_NEED_FPU_LOAD right next to the fpu__initialize() call? It would make it painfully obvious which call is responsible. The naming isn't super helpful here.
Hmm. I was actually thinking of open-coding it all. fpu__initialize() and fpu__drop() have very few callers, and I’m not even convinced that the other callers are calling them for a valid reason.
Fine by me. We all know what the TIF flag does, but its connection to this code is totally opaque. It's a place where removing the abstraction might actually make sense.