On Fri, Jun 07, 2024 at 04:26:38AM +0900, Ryusuke Konishi wrote:
On Thu, Jun 6, 2024 at 11:22 PM Greg Kroah-Hartman wrote:
6.6-stable review patch. If anyone has any objections, please let me know.
From: Ryusuke Konishi konishi.ryusuke@gmail.com
[ Upstream commit 91d743a9c8299de1fc1b47428d8bb4c85face00f ]
Hi Greg,
I have twice raised the suspicion that this patch should not be eligible for stable backport because it is not a bugfix (it just fixes a false positive sparse warning). And you dropped it the first time [1][2].
[1] https://lkml.kernel.org/r/CAKFNMo=kyzbvfLrTv8JhuY=e7-fkjtpL3DvcQ1r+RUPPeC4S9... [2] https://lkml.kernel.org/r/CAKFNMontZ54JxOyK0_xy8P_SfpE0swgq9wiPUErnZ-yrO7wOJ...
On Tue, May 28, 2024 at 3:28 AM Greg KH greg@kroah.com wrote:
This commit fixes the sparse warning output by build "make C=1" with the sparse check, but does not fix any operational bugs.
Therefore, if fixing a harmless sparse warning does not meet the requirements for backporting to stable trees (I assume it does), please drop it as it is a false positive pickup. Sorry if the "Fixes:" tag is confusing.
The same goes for the same patch queued to other stable-trees.
Now dropped, thanks!
greg k-h
Perhaps due to the confusing Fixes tag, this patch appears to have been picked up again. Unless the criteria for its inclusion or exclusion have changed, I think this was selected by mistake. Please check.
Yeah, good catch, now dropped, again.
greg k-h