Re: [PATCH v3] drm/msm/dpu1: don't choke on disabling the writeback connector

On Mon, Dec 09, 2024 at 12:00:07PM +0200, Dmitry Baryshkov wrote: On Mon, 9 Dec 2024 at 11:25, Johan Hovold johan@kernel.org wrote:

...

I noticed that the implementation had this status check also before 71174f362d67 ("drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c").

Why did this not cause any trouble back then? Or is this not the right Fixes tag?

If I remember correctly, the encoder's atomic_check() is called only if the corresponding connector is a part of the new state, if there is a connected CRTC, etc, while the connector's atomic_check() is called both for old and new connectors.

Thanks for the explanation.

Johan