Re: [PATCH v2] rtc: abx80x: Fix return value of nvmem callback on read

On Thu, Jun 13, 2024 at 12:07:50PM +0000, Joy Chakraborty wrote:

Read callbacks registered with nvmem core expect 0 to be returned on success and a negative value to be returned on failure.

abx80x_nvmem_xfer() on read calls i2c_smbus_read_i2c_block_data() which returns the number of bytes read on success as per its api description, this return value is handled as an error and returned to nvmem even on success.

Fix to handle all possible values that would be returned by i2c_smbus_read_i2c_block_data().

Fixes: e90ff8ede777 ("rtc: abx80x: Add nvmem support") Cc: stable@vger.kernel.org Signed-off-by: Joy Chakraborty joychakr@google.com

Thanks!

Reviewed-by: Dan Carpenter dan.carpenter@linaro.org

regards, dan carpenter