On Fri, Sep 20, 2024 at 07:19:28AM -0700, Christoph Hellwig wrote:
On Fri, Sep 20, 2024 at 08:30:22PM +0800, Julian Sun wrote:
Keep it consistent with the handling of the same check within generic_copy_file_checks(). Also, returning -EOVERFLOW in this case is more appropriate.
Maybe:
Keep the errno value consistent with the equivalent check in generic_copy_file_checks() that returns -EOVERFLOW, which feels like the more appropriate value to return compared to the overly generic -EINVAL.
The manpage for clone/dedupe/exchange don't say anything about EOVERFLOW, but they do have this to say about EINVAL:
EINVAL The filesystem does not support reflinking the ranges of the given files.
Does this errno code change cause any regressions in fstests?
--D
Otherwise looks good:
Reviewed-by: Christoph Hellwig hch@lst.de