Re: [Linux-stable-mirror] [PATCH] crypto: rsa - fix buffer overread when stripping leading zeroes

On Sun, 26 Nov 2017, Eric Biggers wrote:

Fixes: 5a7de97309f5 ("crypto: rsa - return raw integers for the ASN.1 parser") Cc: stable@vger.kernel.org # v4.8+ Cc: Tudor Ambarus tudor-dan.ambarus@nxp.com Signed-off-by: Eric Biggers ebiggers@google.com

---

crypto/rsa_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/rsa_helper.c b/crypto/rsa_helper.c index 0b66dc824606..cad395d70d78 100644 --- a/crypto/rsa_helper.c +++ b/crypto/rsa_helper.c @@ -30,7 +30,7 @@ int rsa_get_n(void *context, size_t hdrlen, unsigned char tag, return -EINVAL; if (fips_enabled) {

• while (!*ptr && n_sz) {
  

• while (n_sz && !*ptr) {
  ptr++;
  n_sz--;
  

  }

Reviewed-by: James Morris james.l.morris@oracle.com