Re: [PATCH 3/4] brd: only preload radix tree if we're using a blocking gfp mask

On 2/16/23 8:19?AM, Jens Axboe wrote:

@@ -104,8 +105,10 @@ static int brd_insert_page(struct brd_device *brd, sector_t sector, gfp_t gfp) if (radix_tree_insert(&brd->brd_pages, idx, page)) { __free_page(page); page = radix_tree_lookup(&brd->brd_pages, idx);

• BUG_ON(!page);
  

• BUG_ON(page->index != idx);
  

• if (!page)
  

• 	ret = -ENOMEM;
  

• else if (page->index != idx)
  

• 	ret = -EIO;
  

  } else { brd->brd_nr_pages++; }

After sending this out, noticed that I forgot to change the return 0 to return ret instead. This has been done locally, fwiw.