Re: [PATCH] ucounts: fix counter leak in inc_rlimit_get_ucounts()

On Thu, Oct 31, 2024 at 04:56:01AM +0000, Andrei Vagin wrote:

The inc_rlimit_get_ucounts() increments the specified rlimit counter and then checks its limit. If the value exceeds the limit, the function returns an error without decrementing the counter.

Fixes: 15bc01effefe ("ucounts: Fix signal ucount refcounting") Tested-by: Roman Gushchin roman.gushchin@linux.dev Co-debugged-by: Roman Gushchin roman.gushchin@linux.dev Cc: Kees Cook kees@kernel.org Cc: Andrei Vagin avagin@google.com Cc: "Eric W. Biederman" ebiederm@xmission.com Cc: Alexey Gladkov legion@kernel.org Cc: stable@vger.kernel.org Signed-off-by: Andrei Vagin avagin@google.com

Acked-by: Roman Gushchin roman.gushchin@linux.dev

Thanks!