On 25-01-02 23:50, Vasily Khoruzhick wrote:
Fix 3 typos in 8703b driver. 2 typos in calibration routines are not fatal and do not seem to have any impact, just fix them to match vendor driver.
However the last one in rtw8703b_set_channel_bb() clears too many bits in REG_OFDM0_TX_PSD_NOISE, causing TX and RX issues (neither rate goes above MCS0-MCS1). Vendor driver clears only 2 most significant bits.
With the last typo fixed, the driver is able to reach MCS7 on Pinebook
Cc: stable@vger.kernel.org Fixes: 9bb762b3a957 ("wifi: rtw88: Add definitions for 8703b chip") Signed-off-by: Vasily Khoruzhick anarsoul@gmail.com
Tested-by: Andrey Skvortsov andrej.skvortzov@gmail.com
Thank you, Vasily, for fixing that. Performance is much better with the fix. Here are iperf results made on PinePhone:
1. without the patch using rtw88 driver 1.98 Mbits/sec
2. with the patch using rtw88 driver 14.0 Mbits/sec
3. using old vendor 8723cs driver 23.6 Mbits/sec