On 12/3/20 1:00 AM, Michael Walle wrote:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
This flash part actually has 4 block protection bits.
Reported-by: Tudor Ambarus tudor.ambarus@microchip.com Cc: stable@vger.kernel.org # v5.7+
While the patch is correct according to the datasheet, it was not tested, so it's not a candidate for stable. I would update the commit message to indicate that the the patch was made solely on datasheet info and not tested, I would add the fixes tag, and strip cc-ing to stable.
Signed-off-by: Michael Walle michael@walle.cc
With the above addressed:
Reviewed-by: Tudor Ambarus tudor.ambarus@microchip.com
I didn't add the Fixes: tag because we depend on the 4bit BP support which was introduced in 5.7.
changes since v6:
- new patch
drivers/mtd/spi-nor/sst.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/sst.c b/drivers/mtd/spi-nor/sst.c index e0af6d25d573..0ab07624fb73 100644 --- a/drivers/mtd/spi-nor/sst.c +++ b/drivers/mtd/spi-nor/sst.c @@ -18,7 +18,8 @@ static const struct flash_info sst_parts[] = { SECT_4K | SST_WRITE) }, { "sst25vf032b", INFO(0xbf254a, 0, 64 * 1024, 64, SECT_4K | SST_WRITE) },
{ "sst25vf064c", INFO(0xbf254b, 0, 64 * 1024, 128, SECT_4K) },
{ "sst25vf064c", INFO(0xbf254b, 0, 64 * 1024, 128,
SECT_4K | SPI_NOR_4BIT_BP) }, { "sst25wf512", INFO(0xbf2501, 0, 64 * 1024, 1, SECT_4K | SST_WRITE) }, { "sst25wf010", INFO(0xbf2502, 0, 64 * 1024, 2,
-- 2.20.1