Re: [PATCH net] fbnic: Set napi irq value after calling netif_napi_add

On 12/09/2024 18:49, Brett Creeley wrote:

The driver calls netif_napi_set_irq() and then calls netif_napi_add(), which calls netif_napi_add_weight(). At the end of netif_napi_add_weight() is a call to netif_napi_set_irq(napi, -1), which clears the previously set napi->irq value. Fix this by calling netif_napi_set_irq() after calling netif_napi_add().

This was found when reviewing another patch and I have no way to test this, but the fix seemed relatively straight forward. Cc: stable@vger.kernel.org Fixes: bc6107771bb4 ("eth: fbnic: Allocate a netdevice and napi vectors with queues") Signed-off-by: Brett Creeley brett.creeley@amd.com

I agree that irq vector is lost without this patch.

Reviewed-by: Vadim Fedorenko vadim.fedorenko@linux.dev