Re: [PATCH v2 net] net: Fix null-ptr-deref by sock_lock_init_class_and_name() and rmmod.

From: Simon Horman horms@kernel.org Date: Mon, 7 Apr 2025 11:45:59 +0100

...

diff --git a/include/net/sock.h b/include/net/sock.h index 8daf1b3b12c6..4216d7d86150 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -547,6 +547,10 @@ struct sock { struct rcu_head sk_rcu; netns_tracker ns_tracker; struct xarray sk_user_frags;

+#if IS_ENABLED(CONFIG_PROVE_LOCKING) && IS_ENABLED(CONFIG_MODULES)

• struct module *sk_owner;

+#endif

Not a proper review, but FWIIW, sk_owner should be added to the Kernel doc for struct sock.

Thanks for catching! Will add kdoc in v3.