Re: [PATCH 5.10 261/406] leds: Fix BUG_ON check for LED_COLOR_ID_MULTI that is always false

On Mon, Sep 18, 2023 at 04:00:04PM +0200, Marek Behún wrote:

Greg, please drop this patch from both 5.10 and 5.15.

Reference: https://lore.kernel.org/linux-leds/ZQLelWcNjjp2xndY@duo.ucw.cz/T/

But this is already in released kernels: 6.1.53 6.4.16 6.5.3 6.6-rc1

I am going to send a fix to drop the check altogether.

We will be glad to queue up the fix as well when it hits Linus's tree, please be sure to tag it for stable backporting so we can get it in all locations.

But for now, being bug-compatible makes more sense, right? Or is this really critical and should not be in these kernels now?

thanks,

greg k-h