Re: [PATCH] net: xfrm: fix bug in ipcomp_free_scratches

On Mon, Aug 16, 2021 at 03:38:29PM +0800, Dongliang Mu wrote:

• for_each_possible_cpu(i)

• vfree(*per_cpu_ptr(scratches, i));
  

• for_each_possible_cpu(i) {

• void *scratch = *per_cpu_ptr(scratches, i);
  

• if (!scratch)
  

• 	vfree(scratch);
  

• }

This patch is unnecessary. Please check the implementation of vfree, it already checks for NULL pointers just like most of our free primitives.

Cheers,