21 Dec
2023
21 Dec
'23
7:35 p.m.
On Wed, 20 Dec 2023 17:57:59 +0200 Andy Shevchenko andriy.shevchenko@intel.com wrote:
On Tue, Dec 19, 2023 at 12:18:59PM -0500, Hugo Villeneuve wrote:
From: Hugo Villeneuve hvilleneuve@dimonoff.com
To simplify function by avoiding cast.
This is similar to what is done in max310x driver.
...
If deemed appropriate for stable kernel backporting:
I don't think it's eligible.
No problem.
I don't see the necessity of the change, OTOH it's harmless. The problem is that commit message is basically "Yeah, we do cargo cult." Because I haven't seen what casting you are talking about.
I'll try to reword the commit message.
And replace cast with something like "... to remove additional struct sc16is7xx_port variable..."
Hugo Villeneuve