Hi Jakub, Linus, Ammar,
(sorry for the delay, on vacation, wasn't paying attention to the internet)
On Tue, Aug 05, 2025 at 04:47:47PM -0700, Jakub Kicinski wrote:
On Wed, 6 Aug 2025 01:40:37 +0300 Linus Torvalds wrote:
So my gut feel is that the
if (test_and_clear_bit(EVENT_LINK_CARRIER_ON, &dev->flags)) netif_carrier_on(dev->net);should actually be done outside that if-statement entirely, because it literally ends up changing the thing that if-statement is testing.
Right. I think it should be before the if (!netif_carrier_ok(dev->net))
Ammar, could you retest and repost that, since we haven't heard from John?
I can't verify the suggested change until sometime in September, after I return to office, but it feels correct.
However... I'm almost inclined to suggest a full revert of my patch as the testing was clearly royally botched. Booting it on the boards I have would have shown the failure immediately.
(I did see v3 of this patch being applied)
Apologies for the mess // John Ernberg