objtool points out a condition that it does not like:
lib/ubsan.o: warning: objtool: __ubsan_handle_type_mismatch()+0x4a: call to stackleak_track_stack() with UACCESS enabled lib/ubsan.o: warning: objtool: __ubsan_handle_type_mismatch_v1()+0x4a: call to stackleak_track_stack() with UACCESS enabled
I guess this is related to the call ubsan_type_mismatch_common() not being inline before it calls user_access_restore(), though I don't fully understand why that is a problem.
Marking the function inline shuts up the warning and might be the right thing to do. The patch that caused this is marked for stable backports, so this one should probably be backported as well.
Fixes: 42440c1f9911 ("lib/ubsan: add type mismatch handler for new GCC/Clang") Cc: stable@vger.kernel.org Signed-off-by: Arnd Bergmann arnd@arndb.de --- lib/ubsan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ubsan.c b/lib/ubsan.c index ecc179338094..3d8836f0fc5c 100644 --- a/lib/ubsan.c +++ b/lib/ubsan.c @@ -309,7 +309,7 @@ static void handle_object_size_mismatch(struct type_mismatch_data_common *data, ubsan_epilogue(&flags); }
-static void ubsan_type_mismatch_common(struct type_mismatch_data_common *data, +static __always_inline void ubsan_type_mismatch_common(struct type_mismatch_data_common *data, unsigned long ptr) { unsigned long flags = user_access_save();