Re: [PATCH 5.10 03/29] vdpa_sim: store parsed MAC address in a buffer

Hi!

From: Stefano Garzarella sgarzare@redhat.com

commit cf1a3b35382c10ce315c32bd2b3d7789897fbe13 upstream.

As preparation for the next patches, we store the MAC address, parsed during the vdpasim_create(), in a buffer that will be used to fill 'config' together with other configurations.

I'm not sure why this series is in stable. It is not documented to fix anything bad.

+++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c @@ -42,6 +42,8 @@ static char *macaddr; module_param(macaddr, charp, 0); MODULE_PARM_DESC(macaddr, "Ethernet MAC address"); +u8 macaddr_buf[ETH_ALEN];

Should this be static?

Best regards, Pavel