On Mon, 2018-06-25 at 18:50 +0000, Winkler, Tomas wrote:
On Sun, 2018-06-24 at 23:52 +0300, Tomas Winkler wrote:
Fix tpm ptt initialization error: tpm tpm0: A TPM error (378) occurred get tpm pcr allocation.
We cannot use go_idle cmd_ready commands via runtime_pm handles as with the introduction of localities this is no longer an optional feature, while runtime pm can be not enabled. Though cmd_ready/go_idle provides a power saving, it's also a part of TPM2 protocol and should be called explicitly. This patch exposes cmd_read/go_idle via tpm class ops and removes runtime pm support as it is not used by any driver.
A new tpm transmit flag is added TPM_TRANSMIT_NESTED, which implies TPM_TRANSMIT_UNLOCKED and TPM_TRANSMIT_RAW. Both are needed
to resolve
tpm spaces and locality request recursive calls to tpm_transmit().
New wrappers are added tpm_cmd_ready() and tpm_go_idle() to
streamline
tpm_try_transmit code.
tpm_crb no longer needs own power saving functions and can drop using tpm_pm_suspend/resume.
This patch cannot be really separated from the locality fix. Fixes: 888d867df441 (tpm: cmd_ready command can be issued only after granting locality)
Cc: stable@vger.kernel.org Fixes: 888d867df441 (tpm: cmd_ready command can be issued only after granting locality) Signed-off-by: Tomas Winkler tomas.winkler@intel.com
Please:
- Remove NESTED.
- Where you need call RAW | UNLOCKED.
- Do not add __ prefix.
Should be simple changes to do.
It simple to change, but first you've already agreed on NESTED, second I would appreciate some reasoning behind your requests. There is a logic behind this why RAW is hidden, it's because it always hast be coupled with UNLOCKED, and hence NESTED convers both, it gives cleaner API.
From my side this is NAK.
/Jarkko