From: Alexandru Andries alex.andries.aa@gmail.com
[ Upstream commit 6f80be548588429100eb1f5e25dc2a714d583ffe ]
add DMI entry for ASUS Vivobook PRO 15X (M6501RM) to make the internal microphone function
Signed-off-by: Alexandru Andries alex.andries.aa@gmail.com Link: https://patch.msgid.link/20250707220730.361290-1-alex.andries.aa@gmail.com Signed-off-by: Mark Brown broonie@kernel.org Signed-off-by: Sasha Levin sashal@kernel.org ---
LLM Generated explanations, may be completely bogus:
**YES**
This commit should be backported to stable kernel trees. Here's my extensive analysis:
## Analysis of the Commit
### 1. **Nature of the Change** The commit adds a DMI (Desktop Management Interface) quirk entry for the ASUS Vivobook PRO 15X (M6501RM) laptop to enable its internal microphone functionality. The change is minimal - it simply adds 7 lines to the `yc_acp_quirk_table[]` array in `sound/soc/amd/yc/acp6x-mach.c`:
```c + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "M6501RM"), + } + }, ```
### 2. **Impact and Bug Fix Nature** This is a classic hardware enablement fix that: - **Fixes a real user-facing bug**: The internal microphone on this specific laptop model doesn't work without this quirk - **Has zero functional impact on other systems**: DMI quirks only activate when the exact hardware match is found - **Follows an established pattern**: The file contains dozens of similar DMI quirks for various laptop models
### 3. **Code Context Analysis** From examining the kernel repository: - The `yc_acp_quirk_table[]` is used in the `acp6x_probe()` function to enable DMIC (Digital Microphone) support for AMD Yellow Carp platform - The driver first tries ACPI methods to detect DMIC capability, but falls back to DMI quirks for systems that don't properly advertise this capability - Without this quirk, the microphone simply won't be detected or function on the affected laptop model
### 4. **Comparison with Similar Commits** Looking at the historical patterns: - **3 out of 5 similar DMI quirk additions were marked for stable** (commits with "Cc: stable@vger.kernel.org") - All commits marked "YES" for backporting share these characteristics: - Fix microphone functionality issues - Add simple DMI entries - Have bug reports or user confirmations - Minimal risk of regression
### 5. **Stable Tree Criteria Evaluation** This commit meets all the key stable tree criteria: - ✅ **Fixes a real bug**: Broken microphone functionality - ✅ **Small and contained**: Only 7 lines added - ✅ **No side effects**: Only affects the specific laptop model - ✅ **No architectural changes**: Simple table entry addition - ✅ **Minimal regression risk**: Cannot affect other hardware - ✅ **User-reported issue**: Commit message indicates user need
### 6. **Risk Assessment** The risk is essentially zero because: - DMI matching is exact - it requires both vendor and product name to match - The quirk only enables existing functionality, doesn't modify behavior - Similar quirks have been added hundreds of times without issues - The pattern is well-established in this subsystem
### 7. **Additional Considerations** While this commit doesn't have an explicit "Cc: stable@vger.kernel.org" tag, this is not unusual for AMD audio quirks. The maintainers often rely on stable maintainers to pick up these obvious hardware enablement fixes based on their merit.
This type of hardware enablement fix is exactly what stable kernels should include - it makes Linux work properly on real hardware that users have purchased, without any risk to existing functionality.
sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 1063a19b39aa0..24919e68b3468 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -409,6 +409,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "M6500RC"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "M6501RM"), + } + }, { .driver_data = &acp6x_card, .matches = {