On 12/10/19 2:28 PM, Pavel Begunkov wrote:
Remembered my earlier comment. If the intention is to set HARDLINK, must it go with REQ_F_LINK? And if not, is it ever valid to set them both?
IOSQE_IO_HARDLINK implies IOSQE_IO_LINK, it's the same behavior, just doesn't sever if we get a negative completion result.
That's not like there is a preference, but as it affects userspace, it'd be better to state it clearly and make code to check it.
Agree!