Hi Michael,
On Wed, Jul 5, 2023 at 10:53 AM Michael Schmitz schmitzmic@gmail.com wrote:
Am 05.07.2023 um 19:28 schrieb Geert Uytterhoeven:
On Wed, Jul 5, 2023 at 1:38 AM Michael Schmitz schmitzmic@gmail.com wrote:
Making 'blk' sector_t (i.e. 64 bit if LBD support is active) fails the 'blk>0' test in the partition block loop if a value of (signed int) -1 is used to mark the end of the partition block list.
This bug was introduced in patch 3 of my prior Amiga partition support fixes series, and spotted by Christian Zigotzky when testing the latest block updates.
Explicitly cast 'blk' to signed int to allow use of -1 to terminate the partition block linked list.
Reported-by: Christian Zigotzky chzigotzky@xenosoft.de Fixes: b6f3f28f60 ("block: add overflow checks for Amiga partition support") Message-ID: 024ce4fa-cc6d-50a2-9aae-3701d0ebf668@xenosoft.de
Please drop this line.
Because it's redundant, as I've also used Link:?
(That, too ;-)
Because the use of the Message-ID: tag in patches is not documented. IIRC, it might also cause issues when applying, as the downloaded patch will appear to have two Message-IDs. I'm not sure the sample git hook in Documentation/maintainer/configure-git.rst (and all variants the various maintainers are using) handles this correctly.
Gr{oetje,eeting}s,
Geert