On 2025/2/27 05:30, Rob Herring wrote:
this change ?
We don't know that unless you tested every dts file. We only know that no one has reported an issue yet.
Sorry, my mistake to post the question here for convenience.
actually, i want to ask William this question, and he/she shared applet of the downstream code.
Even if we did test everything, there are DT's that aren't in the kernel tree. It's not like this downstream DT is using some undocumented binding or questionable things. It's a standard binding.
IMO, that may be a downstream bug since they don't refer to binding spec to set property 'alignment'.
Every time this code is touched, it breaks. This is not even the only breakage right now[1].
indeed.
- IMO, the spec may be right. The type of size is enough to express any alignment wanted. For several kernel allocators. type of 'alignment' should be the type of 'size', NOT the type of 'address'
As I said previously, it can be argued either way.
Rob
[1] https://lore.kernel.org/all/20250226115044.zw44p5dxlhy5eoni@pengutronix.de/