Re: [PATCH] qlcnic: fix a memory leak in __qlcnic_pci_sriov_enable()

On 3/5/25 11:18 AM, Haoxiang Li wrote:

Add qlcnic_sriov_free_vlans() to free the memory allocated by qlcnic_sriov_alloc_vlans() if qlcnic_sriov_alloc_vlans() fails.

Fixes: 60ec7fcfe768 ("qlcnic: potential dereference null pointer of rx_queue->page_ring") Cc: stable@vger.kernel.org Signed-off-by: Haoxiang Li haoxiang_li2024@163.com

I think we are better off addressing the problem in qlcnic_sriov_alloc_vlans(), so that eventual future callers of such fuction will not need special handling.

Thanks,

Paolo