[AMD Public Use]
From: Bjorn Helgaas helgaas@kernel.org Sent: Monday, May 3, 2021 11:50 PM To: Keith Busch kbusch@kernel.org Cc: Christoph Hellwig hch@infradead.org; Liang, Prike Prike.Liang@amd.com; linux-nvme@lists.infradead.org; Chaitanya.Kulkarni@wdc.com; gregkh@linuxfoundation.org; stable@vger.kernel.org; Deucher, Alexander Alexander.Deucher@amd.com; S-k, Shyam-sundar <Shyam-sundar.S- k@amd.com>; linux-pci@vger.kernel.org; Rafael J. Wysocki rjw@rjwysocki.net Subject: Re: [PATCH v4 1/2] PCI: add AMD PCIe quirk for nvme shutdown opt
On Mon, May 03, 2021 at 07:57:02AM -0700, Keith Busch wrote:
On Mon, May 03, 2021 at 08:14:07AM +0100, Christoph Hellwig wrote:
On Fri, Apr 30, 2021 at 12:50:49PM -0500, Bjorn Helgaas wrote:
Patch 2/2 only uses PCI_DEV_FLAGS_AMD_NVME_SIMPLE_SUSPEND in
the
nvme driver, so AFAICT there is no reason for the PCI core to keep track of the flag for you.
I see below that Christoph suggests it needs to be in the PCI core, but the reason needs to be explained in the commit log.
As far as I can tell this has nothing to do with NVMe except for the fact that right now it mostly hits NVMe as the nvme drivers is one of the few drivers not always doing a full device shutdown when the system goes into the S3 power state. But various x86 platforms now randomly power done the link in that case.
Right, and the v5 of this series uses a generic name for the PCI quirk without mentioning "NVME".
It'd be nice if somebody would figure out how to cc: linux-pci on these patches.
Thank you for your review. Sorry miss that and now linux-pci has been added to the v5 patch.