Re: [PATCH v3] tpm: Replace WARN_ONCE() with dev_err_once() in tpm_tis_status()

On Wed, Jun 09, 2021 at 04:26:19PM +0300, Jarkko Sakkinen wrote:

Do not tear down the system when getting invalid status from a TPM chip. This can happen when panic-on-warn is used.

Instead, introduce TPM_TIS_INVALID_STATUS bitflag and use it to trigger once the error reporting per chip. In addition, print out the value of TPM_STS for improved forensics.

Link: https://lore.kernel.org/keyrings/YKzlTR1AzUigShtZ@kroah.com/ Fixes: 55707d531af6 ("tpm_tis: Add a check for invalid status") Cc: stable@vger.kernel.org Cc: Hans de Goede hdegoede@redhat.com Cc: Greg KH greg@kroah.com Signed-off-by: Jarkko Sakkinen jarkko@kernel.org

---

Reviewed-by: Greg Kroah-Hartman gregkh@linuxfoundation.org