On 2024/10/29 21:45, Johan Hovold wrote:
On Thu, Oct 24, 2024 at 10:39:28PM +0800, Zijun Hu wrote:
From: Zijun Hu quic_zijuhu@quicinc.com
For devm_phy_destroy(), its comment says it needs to invoke phy_destroy() to destroy the phy, but it does not invoke the function actually since devres_destroy() will not call devm_phy_consume() at all which will call the function, and the missing phy_destroy() call will case that the phy fails to be destroyed.
Here too, split in at least two sentences.
okay.
Fixed by using devres_release() instead of devres_destroy() within the API.
And add a comment about there not being any in-tree users of the interface.
okay, will do it within v2.
And consider dropping it.
okay, will follow the same action as [PATCH 2/6]
Fixes: ff764963479a ("drivers: phy: add generic PHY framework") Cc: stable@vger.kernel.org Signed-off-by: Zijun Hu quic_zijuhu@quicinc.com
Johan