Re: [PATCH RESEND] usb: renesas_usbhs: Add error handling for usbhsf_fifo_select()

On Mon, Apr 14, 2025 at 03:25:01PM +0800, Wentao Liang wrote:

In usbhsf_dcp_data_stage_prepare_pop(), the return value of usbhsf_fifo_select() needs to be checked. A proper implementation can be found in usbhsf_dma_try_pop_with_rx_irq().

Add an error check and jump to PIO pop when FIFO selection fails.

Fixes: 9e74d601de8a ("usb: gadget: renesas_usbhs: add data/status stage handler") Cc: stable@vger.kernel.org # v3.2+ Signed-off-by: Wentao Liang vulab@iscas.ac.cn

---

drivers/usb/renesas_usbhs/fifo.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)

Why is this RESEND? What happened to the first one?

thanks,

greg k-h