Re: [PATCH v2] drm/amdkfd: fix a memory leak in device_queue_manager_init()

…

Move deallocate_hiq_sdma_mqd() up to ensure proper function visibility at the point of use.

…

+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c @@ -2919,6 +2919,14 @@ static int allocate_hiq_sdma_mqd(struct device_queue_manager *dqm) return retval; } +static void deallocate_hiq_sdma_mqd(struct kfd_node *dev,

• 		    struct kfd_mem_obj *mqd)
  

+{

• WARN(!mqd, "No hiq sdma mqd trunk to free");
• amdgpu_amdkfd_free_gtt_mem(dev->adev, &mqd->gtt_mem);

+}

Is there also a need to reconsider the implementation of the applied null pointer check here?

Regards, Markus