Re: [PATCH] wifi: wilc1000: use vmm_table as array in wilc struct

Hello Michael,

On 10/13/23 11:24, Michael Walle wrote:

...

Fixes: 40b717bfcefa ("wifi: wilc1000: fix DMA on stack objects") Cc: stable@vger.kernel.org Signed-off-by: Ajay Singh ajay.kathat@microchip.com Signed-off-by: Alexis Lothoré alexis.lothore@bootlin.com

Looks good to me. But you'll change the alignment of the table, not sure if that matters for some DMA controllers.

Thanks for the review. Indeed, I may have overlooked that point. I am not sure either how much of an issue it could be, but checking back the driver history on lore, I see that it has already been mentioned, so let's be safe and keep a dedicated kzalloc for vmm_table to make sure its address is safe to use with DMA. I will send the corresponding v2.

Thanks, Alexis

-michael