On Thu, Sep 08, 2022 at 03:02:41PM +0300, Amir Goldstein wrote:
On Thu, Sep 8, 2022 at 2:48 PM Greg KH gregkh@linuxfoundation.org wrote:
On Tue, Sep 06, 2022 at 06:36:00PM +0000, Varsha Teratipally wrote:
From: Christoph Hellwig hch@lst.de
XFS always inherits the SGID bit if it is set on the parent inode, while the generic inode_init_owner does not do this in a few cases where it can create a possible security problem, see commit 0fa3ecd87848 ("Fix up non-directory creation in SGID directories") for details.
Switch XFS to use the generic helper for the normal path to fix this, just keeping the simple field inheritance open coded for the case of the non-sgid case with the bsdgrpid mount option.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: Christian Brauner christian.brauner@ubuntu.com Signed-off-by: Christoph Hellwig hch@lst.de Reviewed-by: Darrick J. Wong djwong@kernel.org Signed-off-by: Darrick J. Wong djwong@kernel.org
Why did you not sign off on this if you are forwarding it on?
Also, what is the git id of this commit in Linus's tree (we need that hint...)
Please fix both up and resend and get the ack of the stable xfs developers on it as well.
Varsha,
FWIW, I re-tested the patch on top of v5.10.141, so when re-posting [PATCH 5.10] you may add:
Tested-by: Amir Goldstein amir73il@gmail.com
Darrick or Christoph,
Can you please ACK this patch?
With all the bookkeepping bits corrected (and assuming that the VFS fixes have been or are about to be applied):
Acked-by: Darrick J. Wong djwong@kernel.org
--D
Thanks, Amir.