On 12/9/19 9:54 AM, Ajay Kaher wrote:
On 06/12/19, 8:02 PM, "Vlastimil Babka" vbabka@suse.cz wrote:
On 12/6/19 5:15 AM, Ajay Kaher wrote:
On 03/12/19, 6:28 PM, "Vlastimil Babka" vbabka@suse.cz wrote:
[ 4.4 backport: there's get_page_foll(), so add try_get_page()-like checks in there, enabled by a new parameter, which is false where upstream patch doesn't replace get_page() with try_get_page() (the THP and hugetlb callers).
Could we have try_get_page_foll(), as in: https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kerne...
- Code will be in sync as we have try_get_page()
- No need to add extra argument to try_get_page()
- No need to modify the callers of try_get_page()
Any reason for not using try_get_page_foll().
Ah, sorry, I missed that previously. It's certainly possible to do it that way, I just didn't care so strongly to rewrite the existing SLES patch. It's a stable backport for a rather old LTS, not a codebase for further development.
Thanks for your response.
I would appreciate if you would like to include try_get_page_foll(), and resend this patch series again.
I won't have time for that now, but I don't mind if you do that, or resend your version with the missing x86 and s390 gup.c parts and preferably without 7aef4172c795.